path: Fix the error message of path.format#14030
Closed
starkwang wants to merge 1 commit intonodejs:masterfrom
Closed
path: Fix the error message of path.format#14030starkwang wants to merge 1 commit intonodejs:masterfrom
starkwang wants to merge 1 commit intonodejs:masterfrom
Conversation
mscdex
reviewed
Jul 1, 2017
| if (pathObject === null || typeof pathObject !== 'object') { | ||
| throw new errors.TypeError('ERR_INVALID_ARG_TYPE', 'pathObject', 'Object', | ||
| typeof pathObject); | ||
| pathObject); |
Contributor
There was a problem hiding this comment.
Can we align this with the argument above it?
Contributor
Author
There was a problem hiding this comment.
It will exceed the maximum line length of 80
mscdex
reviewed
Jul 1, 2017
| if (pathObject === null || typeof pathObject !== 'object') { | ||
| throw new errors.TypeError('ERR_INVALID_ARG_TYPE', 'pathObject', 'Object', | ||
| typeof pathObject); | ||
| pathObject); |
Contributor
|
I think these fixes are already in #14011. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last argument of
invalidArgType(name, expected, actual)in internal/errors.js is an actual value, NOT the type of actual value.This causes:
The last word "string" should be "number".
A parallel test is added for this method.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
path